git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sideband: color lines with keyword only

From
Han-Wen Nienhuys <hanwen@google.com>
Date
Dec 10, 2018, 11:03 UTC
Message-ID
<CAFQ2z_OnekMUu=AomfoBoa=4dYThtEfa4sxf+UkSMAFspxeV3w@mail.gmail.com>
In-Reply-To
<20181203232353.GA157301@google.com>
On Tue, Dec 4, 2018 at 12:23 AM Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 6 quoted lines
> > When bf1a11f0a1 (sideband: highlight keywords in remote sideband output,
> > 2018-08-07) was introduced, it was carefully considered which strings
> > would be highlighted. However 59a255aef0 (sideband: do not read beyond
> > the end of input, 2018-08-18) brought in a regression that the original
> > did not test for. A line containing only the keyword and nothing else
> > ("SUCCESS") should still be colored.

I had intended SUCCESS on a line of its to be highlighted too, and some earlier versions of my patch did that, but it regressed as the patch was reworked. The SUCCESS on a line of its own is a recent behavior of Gerrit, and is live in Gerrit 2.16.

--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Previous: Junio C Hamano
Message 7 of 7 in “sideband: color lines with keyword only”
  1. sideband: color lines with keyword onlyStefan Beller, Dec 3, 2018
  2. Jonathan NiederDec 3, 2018
  3. Jonathan NiederDec 3, 2018
  4. Stefan BellerDec 3, 2018
  5. Jonathan NiederDec 3, 2018
  6. Junio C HamanoDec 4, 2018
  7. Han-Wen NienhuysDec 10, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.