From: Han-Wen Nienhuys Date: Mon, 10 Dec 2018 11:03:11 GMT Subject: Re: [PATCH] sideband: color lines with keyword only Message-ID: In-Reply-To: <20181203232353.GA157301@google.com> On Tue, Dec 4, 2018 at 12:23 AM Jonathan Nieder wrote: > > When bf1a11f0a1 (sideband: highlight keywords in remote sideband output, > > 2018-08-07) was introduced, it was carefully considered which strings > > would be highlighted. However 59a255aef0 (sideband: do not read beyond > > the end of input, 2018-08-18) brought in a regression that the original > > did not test for. A line containing only the keyword and nothing else > > ("SUCCESS") should still be colored. I had intended SUCCESS on a line of its to be highlighted too, and some earlier versions of my patch did that, but it regressed as the patch was reworked. The SUCCESS on a line of its own is a recent behavior of Gerrit, and is live in Gerrit 2.16. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado