git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] refs.h: make all flags arguments unsigned

From
Han-Wen Nienhuys <hanwen@google.com>
Date
Feb 3, 2022, 18:33 UTC
Message-ID
<CAFQ2z_Mmfp4wrHNo92ke7i7UF2bDL9v4oddRC4UKN0R9h2C-6Q@mail.gmail.com>
In-Reply-To
<xmqqo83nvm8w.fsf@gitster.g>
On Thu, Feb 3, 2022 at 7:27 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 19 quoted lines
> > Yes, enums or not, what I was also pointing out in
> > https://lore.kernel.org/git/220201.86ilty9vq2.gmgdl@evledraar.gmail.com/
> > is that changing just one logical set of flags at a time would make this
> > much easier to review.
>
> Another thing to consider is how to make this play better with other
> topics in flight.  Basing a huge single patch on top of 'seen' is a
> way to ensure that the patch will never be useful.  There won't be a
> good time when such a topic can graduate.  The topic will also have
> a hard time keeping up with what new topics add while waiting for
> what happen to be in 'seen' today (some of which may even go away
> without graduating) all graduate.
>
> Limiting the scope to small and more stable subset of flags that are
> in 'master' and does not conflict (e.g. no new bit defined to the
> set of flags, no existing bit gets removed, no new callers that use
> the bitset introduced) with other topics would incrementally improve
> the code base, and makes progress in the sense that it reduces the
> remaining work.

OK. But do we agree we want to use enums? Me and AEvar are in favor, anyone against?

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Previous: Junio C HamanoNext: Junio C Hamano
Message 13 of 17 in “refs.h: make all flags arguments unsigned”
  1. refs.h: make all flags arguments unsignedHan-Wen Nienhuys via GitGitGadget, Jan 31, 2022
  2. Junio C HamanoFeb 1, 2022
  3. Han-Wen NienhuysFeb 1, 2022
  4. Junio C HamanoFeb 1, 2022
  5. refs.h: make all flags arguments unsignedHan-Wen Nienhuys via GitGitGadget, Feb 1, 2022
  6. Ævar Arnfjörð BjarmasonFeb 1, 2022
  7. Junio C HamanoFeb 1, 2022
  8. Han-Wen NienhuysFeb 3, 2022
  9. Ævar Arnfjörð BjarmasonFeb 3, 2022
  10. Han-Wen NienhuysFeb 3, 2022
  11. Ævar Arnfjörð BjarmasonFeb 3, 2022
  12. Junio C HamanoFeb 3, 2022
  13. Han-Wen NienhuysFeb 3, 2022
  14. Junio C HamanoFeb 3, 2022
  15. 0/2 refs.h: make all flags arguments unsignedHan-Wen Nienhuys via GitGitGadget, Feb 3, 2022
  16. 1/2 refs.h: make all flags arguments unsignedHan-Wen Nienhuys via GitGitGadget, Feb 3, 2022
  17. 2/2 Uniformize flag argument naming to `flags` or `unused_flags`Han-Wen Nienhuys via GitGitGadget, Feb 3, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.