git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Feature request: provide a persistent IDs on a commit

From
Han-Wen Nienhuys <hanwen@google.com>
Date
Jul 21, 2022, 11:57 UTC
Message-ID
<CAFQ2z_Mc6Z-FyFkUURMCM11yQTH+Y2PLBrAKB-16BXv159=oOA@mail.gmail.com>
In-Reply-To
<Yth9TCCEXfmagaaw@mit.edu>
On Thu, Jul 21, 2022 at 12:10 AM Theodore Ts'o <tytso@mit.edu> wrote:
Show 30 quoted lines
> On Wed, Jul 20, 2022 at 03:21:44PM -0400, Konstantin Ryabitsev wrote:
> > The kernel community has repeatedly rejected per-patch Change-id trailers
> > because they carry no meaningful information outside of the gerrit system on
> > which they were created. Seeing a Change-Id trailer in a commit tells you
> > nothing about the history of that commit unless you know the gerrit system on
> > which this patch was reviewed (and have access to it, which is not a given).
>
> The "no meaningful information outside of the gerrit system" is the
> key.  This was extensively discussed in the
> ksummit-discuss@lists.linux-foundation.org mailing list in late August
> 2019, subject line "Allowing something Change-Id (or something like
> it) in kernel commits".  Quoting from Linus Torvalds:
>
>     From: Linus Torvalds
>     Date: Thu, 22 Aug 2019 17:17:05 -0700
>     Message-Id: CAHk-=whFbgy4RXG11c_=S7O-248oWmwB_aZOcWzWMVh3w7=RCw@mail.gmail.com
>
>     No. That's not it at all. It's not "dislike gerrit".
>
>     It's "dislike pointless garbage".
>
>     If the gerrit database is public and searchable using the uuid, then
>     that would make the uuid useful to outsiders. And instead of just
>     putting a UUID (which is hard to look up unless you know where it came
>     from), make it be that "Link:" that gives not just the UUID, but also
>     gives you the metadata for that UUID to be looked up.
>..
>     So if you guys make the gerrit database actually public, and then
>     start adding "Link: ..." tags so that we can see what they point to, I
>     think people will be more than supportive of it.

Support for the "Link:" footer as a change ID has been implemented in Gerrit as of https://gerrit.googlesource.com/gerrit/+/8cab93302d9c35316d691e848b67e687a68182b5 (available in Gerrit 3.3 and onwards). I'm not sure if it has seen much use, though.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Liana Sebastian
Previous: Theodore Ts'oNext: Elijah Newren
Message 9 of 30 in “Feature request: provide a persistent IDs on a commit”
  1. Stephen FinucaneJul 18, 2022
  2. Konstantin RyabitsevJul 18, 2022
  3. Michal SuchánekJul 18, 2022
  4. Stephen FinucaneJul 19, 2022
  5. Glen ChooJul 18, 2022
  6. Konstantin RyabitsevJul 20, 2022
  7. Michal SuchánekJul 20, 2022
  8. Theodore Ts'oJul 20, 2022
  9. Han-Wen NienhuysJul 21, 2022
  10. Elijah NewrenJul 24, 2022
  11. Ævar Arnfjörð BjarmasonJul 18, 2022
  12. Stephen FinucaneJul 19, 2022
  13. Ævar Arnfjörð BjarmasonJul 19, 2022
  14. Michal SuchánekJul 19, 2022
  15. Stephen FinucaneJul 29, 2022
  16. Jason PyeronJul 29, 2022
  17. Phillip SusiJul 21, 2022
  18. Hilco WijbengaJul 21, 2022
  19. Philip OakleyJul 22, 2022
  20. Michal SuchánekJul 22, 2022
  21. Jacob KellerJul 22, 2022
  22. Michal SuchánekJul 23, 2022
  23. Elijah NewrenJul 24, 2022
  24. Michal SuchánekJul 24, 2022
  25. Jacob KellerJul 25, 2022
  26. Elijah NewrenJul 26, 2022
  27. Michal SuchánekJul 26, 2022
  28. Elijah NewrenJul 24, 2022
  29. Michal SuchánekJul 24, 2022
  30. Martin von ZweigbergkDec 15, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.