Re: [RFC/PATCH] rebase--interactive: Add "sign" command

From: Chris Packham <judge.packham@gmail.com>
Date: Aug 4, 2016, 00:53 UTC
Message-ID: <CAFOYHZB080T51QYLaaJasoaJyBycjTRBrNQ-Gh2fitz-fcS5Sw@mail.gmail.com>
In-Reply-To: <20160803180820.2raazmsfjavoaogo@sigill.intra.peff.net>

On Thu, Aug 4, 2016 at 6:08 AM, Jeff King <peff@peff.net> wrote:

Show 22 quoted lines

> On Wed, Aug 03, 2016 at 09:08:48AM -0700, Junio C Hamano wrote:
>
>> > However, I could imagine that we actually want this to be more extensible.
>> > After all, all you are doing is to introduce a new rebase -i command that
>> > does nothing else than shelling out to a command.
>>
>> Yup, I tend to agree.
>>
>> Adding "sign" feature (i.e. make it pass -S to "commit [--amend]")
>> may be a good thing, but adding "sign" command to do so is not a
>> great design.
>
> I'm not sure what you mean by "feature" here, but it reminded me of
> Michael's proposal to allow options to todo lines:
>
>   http://public-inbox.org/git/530DA00E.4090402@alum.mit.edu/
>
> which would allow:
>
>   pick -S 1234abcd
>
> If that's what you meant, I think it is a good idea. :)

That would definitely suit me. I see there was some discussion of which options were sensible to support. --signoff and --reset-author would be a good start from my point of view. Maybe that's something that could be build on top of Johannes work.

>
> -Peff