Re: [RFC/PATCH] rebase--interactive: Add "sign" command

From: Jeff King <peff@peff.net>
Date: Aug 3, 2016, 18:08 UTC
Message-ID: <20160803180820.2raazmsfjavoaogo@sigill.intra.peff.net>
In-Reply-To: <xmqqr3a5al7z.fsf@gitster.mtv.corp.google.com>

On Wed, Aug 03, 2016 at 09:08:48AM -0700, Junio C Hamano wrote:

Show 9 quoted lines

> > However, I could imagine that we actually want this to be more extensible.
> > After all, all you are doing is to introduce a new rebase -i command that
> > does nothing else than shelling out to a command.
> 
> Yup, I tend to agree.
> 
> Adding "sign" feature (i.e. make it pass -S to "commit [--amend]")
> may be a good thing, but adding "sign" command to do so is not a
> great design.

I'm not sure what you mean by "feature" here, but it reminded me of Michael's proposal to allow options to todo lines:

  http://public-inbox.org/git/530DA00E.4090402@alum.mit.edu/

which would allow:

  pick -S 1234abcd

If that's what you meant, I think it is a good idea. :)

-Peff