git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: compactionHeuristic=true is not used by interactive staging

From
APAlex Prengère <alexprengere@gmail.com>
Date
Jun 15, 2016, 06:24 UTC
Message-ID
<CAEtHF9Ne7a25cOF_6L=ZXRnmR4NbnUBDFR+6V-PryjtK8yNO8g@mail.gmail.com>
In-Reply-To
<xmqq37of8mx4.fsf@gitster.mtv.corp.google.com>

I see, it makes sense ;-) Indeed it would seem logical to have all commands showing diffs (diff, add -p, log -p, reset -p, etc..) respect the diff options.

Thanks for your quick answer!
2016-06-14 23:45 GMT+02:00 Junio C Hamano <gitster@pobox.com>:
Show 8 quoted lines
> Jeff King <peff@peff.net> writes:
>
>> Nobody noticed so far because originally the compaction heuristic was on
>> by default, and so just worked everywhere. But we backed off on that at
>> the last minute after finding a few cases where the diff looks worse.
>
> Yup, and that is why this is called "experimental" in the release
> notes ;-)
Previous: Junio C HamanoNext: Jeff King
Message 4 of 7 in “compactionHeuristic=true is not used by interactive staging”
  1. Alex PrengèreJun 14, 2016
  2. Jeff KingJun 14, 2016
  3. Junio C HamanoJun 14, 2016
  4. Alex PrengèreJun 15, 2016
  5. add--interactive: respect diff.compactionHeuristicJeff King, Jun 16, 2016
  6. Stefan BellerJun 16, 2016
  7. Jeff KingJun 16, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.