Re: [PATCH] add--interactive: respect diff.compactionHeuristic

From: Jeff King <peff@peff.net>
Date: Jun 16, 2016, 23:40 UTC
Message-ID: <20160616234043.GC15013@sigill.intra.peff.net>
In-Reply-To: <CAGZ79kaPVFT=yeSAkmf55+qXcCgMkwpgkC8jXhuZvqj5mWtgLw@mail.gmail.com>

On Thu, Jun 16, 2016 at 09:50:45AM -0700, Stefan Beller wrote:

Show 14 quoted lines

> > -- >8 --
> > Subject: add--interactive: respect diff.compactionHeuristic
> >
> > We use plumbing to generate the diff, so it doesn't
> > automatically pick up UI config like compactionHeuristic.
> > Let's forward it on, since interactive adding is porcelain.
> >
> > Note that we only need to handle the "true" case. There's no
> > point in passing --no-compaction-heuristic when the variable
> > is false, since nothing else could have turned it on.
> 
> because we don't want to implement --[no-]compaction-heuristic
> as a command line switch to git-add?
> Fine with me.

We could, but I don't think it is worth the effort (and anyway, it would override the config :) ).

Show 5 quoted lines

> Stepping back and looking how the compaction heuristic turned out,
> I think this is what we did not want to see, i.e. the need to bring it in
> every command, but rather enable and release it. But we backed off
> of the default-on, and now people may ask for the  --no-compaction-heuristic
> in interactive add eventually, when they run into a corner case.

Yeah, I'm not excited to be plumbing it through, especially if we just end up flipping it on by default. But perhaps people would still want to be able to do the opposite (turning it off for a specific case via the config). I dunno.

> For now:
> Reviewed-by: Stefan Beller <sbeller@google.com>

Thanks.

-Peff