git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add --recursive flag to git bash completion script.

From
Thomas Ferris Nicolaisen <tfnico@gmail.com>
Date
Mar 9, 2015, 10:43 UTC
Message-ID
<CAEcj5uVCudOV3a9BaWnwY=dvAOGmPfYfBeFBS9y2vyrzBBZbOQ@mail.gmail.com>
In-Reply-To
<1425859216.8244.40.camel@gmail.com>
On Mon, Mar 9, 2015 at 1:00 AM, James <purpleidea@gmail.com> wrote:
> This is a patch to add a much needed option to the bash completion
> script. I'm not subscribed to this list, so please include me in your
> reply if you'd like me to see your response.
Please read the guide on how to submit patches [1].
Although the change is trivial, some immediate problems I see are:
* The patch is attached rather than being inlined.
* The fix should also be made for the other shells (zsh and tcsh)
* The commit message contains an unnecessary smiley, personal
digression, and a period in the first line.
* The change or the problem it is solving is not clearly described. I
think it would be better if you write something like this in the first
line:
"completion: add --recursive flag to git clone"

And for good measure, add another sentence below explaining why this should be available for completion.

Do a `git log --grep completion` to see how others have formulated changes in the same place in the past. You want to be consistent with them.

[1] https://raw.githubusercontent.com/git/git/master/Documentation/SubmittingPatches
Previous: James
Message 2 of 2 in “Add --recursive flag to git bash completion script.”
  1. Add --recursive flag to git bash completion script.James, Mar 9, 2015
  2. Thomas Ferris NicolaisenMar 9, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.