From: Thomas Ferris Nicolaisen <tfnico@gmail.com>
Date: Mon, 09 Mar 2015 10:43:53 GMT
Subject: Re: [PATCH] Add --recursive flag to git bash completion script.
Message-ID: <CAEcj5uVCudOV3a9BaWnwY=dvAOGmPfYfBeFBS9y2vyrzBBZbOQ@mail.gmail.com>
In-Reply-To: <1425859216.8244.40.camel@gmail.com>

On Mon, Mar 9, 2015 at 1:00 AM, James <purpleidea@gmail.com> wrote:
> This is a patch to add a much needed option to the bash completion
> script. I'm not subscribed to this list, so please include me in your
> reply if you'd like me to see your response.

Please read the guide on how to submit patches [1].

Although the change is trivial, some immediate problems I see are:

* The patch is attached rather than being inlined.
* The fix should also be made for the other shells (zsh and tcsh)
* The commit message contains an unnecessary smiley, personal
digression, and a period in the first line.
* The change or the problem it is solving is not clearly described. I
think it would be better if you write something like this in the first
line:

"completion: add --recursive flag to git clone"

And for good measure, add another sentence below explaining why this
should be available for completion.

Do a `git log --grep completion` to see how others have formulated
changes in the same place in the past. You want to be consistent with
them.

[1] https://raw.githubusercontent.com/git/git/master/Documentation/SubmittingPatches