git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] config: add show_err flag to git_config_parse_key()

From
Tanay Abhra <tanayabh@gmail.com>
Date
Oct 30, 2014, 18:25 UTC
Message-ID
<CAEc54XBWbBNzkh6OqBoMpMkO07qyDEOJ8vd8AN-tRWa9wKDJZg@mail.gmail.com>
In-Reply-To
<xmqqd299wh9m.fsf@gitster.dls.corp.google.com>
Show 20 quoted lines
>> ---
>>
>> Hi,
>>
>> You were right, one of the functions was calling git_config_parse_key()
>> which was leaking errors to the console. git_config_parse_key() was
>> meant for sanitizing user provided keys only but it was being used
>> internally in a place where only a return value would be enough.
>>
>> Thanks for bringing this to our attention.
>>
>> Cheers,
>> Tanay Abhra.
>
> Who are *you* in the above, and what was the bug report about (if it
> was a bug report)?  Perhaps summarize it in a form of a few new tests
> in t/t13XX series is in order?
>
> Thanks.
>

Sorry about that, I am behind a firewall and had to use the gmail web interface. The patches are butchered, I will send new ones with a proper connection tomorrow.

The original bug report is at [1].
http://thread.gmane.org/gmane.comp.version-control.git/258886
Previous: Junio C Hamano
Message 3 of 3 in “config: add show_err flag to git_config_parse_key()”
  1. config: add show_err flag to git_config_parse_key()Tanay Abhra, Oct 30, 2014
  2. Junio C HamanoOct 30, 2014
  3. Tanay AbhraOct 30, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.