From: Tanay Abhra <tanayabh@gmail.com>
Date: Thu, 30 Oct 2014 18:25:42 GMT
Subject: Re: [PATCH] config: add show_err flag to git_config_parse_key()
Message-ID: <CAEc54XBWbBNzkh6OqBoMpMkO07qyDEOJ8vd8AN-tRWa9wKDJZg@mail.gmail.com>
In-Reply-To: <xmqqd299wh9m.fsf@gitster.dls.corp.google.com>

>> ---
>>
>> Hi,
>>
>> You were right, one of the functions was calling git_config_parse_key()
>> which was leaking errors to the console. git_config_parse_key() was
>> meant for sanitizing user provided keys only but it was being used
>> internally in a place where only a return value would be enough.
>>
>> Thanks for bringing this to our attention.
>>
>> Cheers,
>> Tanay Abhra.
>
> Who are *you* in the above, and what was the bug report about (if it
> was a bug report)?  Perhaps summarize it in a form of a few new tests
> in t/t13XX series is in order?
>
> Thanks.
>

Sorry about that, I am behind a firewall and had to use the gmail web interface.
The patches are butchered, I will send new ones with a proper connection
tomorrow.

The original bug report is at [1].

http://thread.gmane.org/gmane.comp.version-control.git/258886