Re: [PATCH v2] t3310: avoid hiding failures from rev-parse in command substitutions

From: Francesco Paparatto <francescopaparatto@gmail.com>
Date: Mar 5, 2026, 22:49 UTC
Message-ID: <CAEaT9__LELMsCVZoY57+JZ8S0AtcE4n=K2W-rqjJhz2UDPiUBA@mail.gmail.com>
In-Reply-To: <CAPig+cTsYWVg0nrU7kMakOKQaqFSo=i_nZ=_YuCJK_hq5gdZPQ@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 6 quoted lines

> What Junio probably means is that you appear to have based v2 atop v1,
> but instead you should squash v1 and v2 into a single patch, and send
> that as v3 so that when the patch is finally accepted into his tree,
> it will appear to have been perfect from the start (because v1 and v2
> will only exist in the mailing list archive, not in the Git project
> history).

Sorry about that, and thanks for the clarification.

I've squashed the changes and rerolled the patch based on your suggestions. I've just sent v3 to the list.

Thanks, Francesco