Re: [PATCH v2] t3310: avoid hiding failures from rev-parse in command substitutions

From: Francesco Paparatto <francescopaparatto@gmail.com>
Date: Mar 5, 2026, 22:42 UTC
Message-ID: <CAEaT9_-h2MEshMHoyoW9kWQgt_EfQJXcxWSn+cXTSL4mKME=5w@mail.gmail.com>
In-Reply-To: <xmqq5x7a3x9w.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Hmph, did I suggest this?  I know Eric had comments on a previous
> round, and the improvements in this patch seems to be influenced a
> lot stronger by his input than whatever I may have said.

Sorry about the Suggested-by line. I added it because of your earlier comment here:

    https://public-inbox.org/git/xmqqv7fioueg.fsf@gitster.g/

but you're right that the concrete changes in this version were mostly influenced by Eric's review, so I'll drop that trailer.

> On top of what commit is this patch designed to apply?

This patch is based on top of:

    b3ec5aec2367262f464a33d6eab7a9f49fd413f1
    ("t3310: replace test -f/-d with test_path_is_file/test_path_is_dir")

I'll reroll and send a v3 of the patch shortly.

Thanks, Francesco