Re: [PATCH] git-cvsimport: allow author-specific timezones

From: Chris Rorvick <chris@rorvick.com>
Date: Oct 16, 2012, 02:26 UTC
Message-ID: <CAEUsAPY3fJJSzX8WPRVQPNOF0A0KAMCXr1u0ZzjEFvXDF=v6JA@mail.gmail.com>
In-Reply-To: <7vpq4jws4d.fsf@alter.siamese.dyndns.org>

On Mon, Oct 15, 2012 at 12:40 PM, Junio C Hamano <gitster@pobox.com> wrote:

>> diff --git a/t/t9604-cvsimport-timestamps.sh b/t/t9604-cvsimport-timestamps.sh
>> new file mode 100644
>
> Huh?  What happened to the executable bit we saw earlier?

Uh, yeah.  Sorry about that.

Show 7 quoted lines

>> +test_expect_success 'check timestamps are UTC (TZ=Australia/Sydney)' '
>> +
>> +    TZ=America/Chicago git cvsimport -p"-x" -C module-2 module &&
>
> This look identical to the first one, but even with a trivial change
> to use Australia/Sydney instead of Chicago, I am not sure what the
> test buys us.

This is left over from when I was using the script to test the "use local timezone" option. It was useless there, too, but did provide some symmetry. :-) Removed.

It occurred to me that the success of the unit test depends on the host platform's zoneinfo database. I think this problem is inherent with this functionality. Should the unit test attempt to detect support for the used timezones and short circuit if this fails? Not sure exactly how I'd do this, but wondering if it's worth thinking about.

I've made all the other recommended changes, I'll resubmit shortly.

Thanks,

Chris