Re: [PATCH] git-cvsimport: allow author-specific timezones

From: Jeff King <peff@peff.net>
Date: Oct 16, 2012, 06:31 UTC
Message-ID: <20121016063152.GB22941@sigill.intra.peff.net>
In-Reply-To: <7v4nlvulc2.fsf@alter.siamese.dyndns.org>

On Mon, Oct 15, 2012 at 08:50:21PM -0700, Junio C Hamano wrote:

Show 13 quoted lines

> Chris Rorvick <chris@rorvick.com> writes:
> 
> > It occurred to me that the success of the unit test depends on the
> > host platform's zoneinfo database.  I think this problem is inherent
> > with this functionality.  Should the unit test attempt to detect
> > support for the used timezones and short circuit if this fails?  Not
> > sure exactly how I'd do this, but wondering if it's worth thinking
> > about.
> 
> Yeah, that did indeed cross my mind.
> 
> You could say TZ=QST6QDT or something silly like that but that in
> turn has to assume your tzset() is POSIX.1 compliant anyway.

We use EST5 in t0006 (it was originally just "EST" but IRIX complained). It's been in the test suite for two years without a problem, so it may be simple and safe enough to just use that.

-Peff