Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

From: Benoît Person <benoit.person@ensimag.fr>
Date: Jul 3, 2013, 09:46 UTC
Message-ID: <CAETqRCjPkjZiKDmRc8TP-kZXOJwKn-_X2Bvnuqp=fJKRcwtuEw@mail.gmail.com>
In-Reply-To: <7vhagcgh0e.fsf@alter.siamese.dyndns.org>

Show 7 quoted lines

>> For now, GITPERLLIB is only used in that kind of statements:
>> use lib (split(/:/, $ENV{GITPERLLIB} || ... ));
>>
>> The trailing ':' does not really matter, split will ignore it.
>
> That may be true with the current use, but "For now" leaves funny
> taste, doesn't it?

definitely. For me, the issue was that we were trading that "funny taste" for less readable code in wrap-for-bin.sh but with that default-substitution construct, it seems worth it. (a huge if-block seemed even funnier in fact :) )

Show 6 quoted lines

> It is not too much trouble to fix by writing
>
>   GITPERLLIB='@@BUILD_DIR@@/perl/blib/lib'"${GITPERLLIB:+:$GITPERLLIB}"
>
> and we will not have to be worried about future changes breaking
> today's assumption.

That construct is really nice :) did not know there was such a thing in bash, thanks.