Re: [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 3, 2013, 08:54 UTC
Message-ID: <7vhagcgh0e.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAETqRChiW49TwrZiZoi6vCwe9yOjurn97QpPEcJ2pb6fvp3ZBQ@mail.gmail.com>

Benoît Person <benoit.person@ensimag.fr> writes:

Show 7 quoted lines

>> Do we want to add that ':' unconditionally?  Could GITPERLLIB be
>> empty?
>
> For now, GITPERLLIB is only used in that kind of statements:
> use lib (split(/:/, $ENV{GITPERLLIB} || ... ));
>
> The trailing ':' does not really matter, split will ignore it.

That may be true with the current use, but "For now" leaves funny taste, doesn't it?

It is not too much trouble to fix by writing

  GITPERLLIB='@@BUILD_DIR@@/perl/blib/lib'"${GITPERLLIB:+:$GITPERLLIB}"

and we will not have to be worried about future changes breaking today's assumption.