Re: [RFC PATCH] git-p4: add option to store files in Git LFS on import
- From
Luke Diamand <luke@diamand.org>
- Date
- Aug 30, 2015, 16:36 UTC
- Message-ID
- <CAE5ih7-w5ZjO=QUE45yBvwyqdqKCADczrLt7=4W8X6BR+cy4PA@mail.gmail.com>
- In-Reply-To
- <9951C805-DFBF-47AC-B215-B9C657D4A852@gmail.com>
On 30 August 2015 at 11:18, Lars Schneider <larsxschneider@gmail.com> wrote:
> Thanks for your feedback! > > I like the “handle big files” plugin kind of idea. However, I wonder if it makes sense to put more and more stuff into git-p4.py (>3000 LOC already). What do you think about splitting git-p4 into multiple files?
I was wondering about that. I think for now, the simplicity of keeping everything in one file is worth the slight extra pain. I don't imagine that the big-file-handler code would be very large.
> > Regarding Python 3: > Would you drop Python 2 support or do you want to support Python 2/3 in parallel? I would prefer the former…
For quite some time we would need to support both; we can't just have a release of git that one day breaks git-p4 for people stuck on Python 2. But it might not be that hard to support both (though converting all those print statements could be quite tiresome).