Re: [RFC PATCH] git-p4: add option to store files in Git LFS on import
- From
Lars Schneider <larsxschneider@gmail.com>
- Date
- Sep 3, 2015, 09:40 UTC
- Message-ID
- <1D65DD68-EE3F-4C87-9B5F-E436BA13704E@gmail.com>
- In-Reply-To
- <CAE5ih7-w5ZjO=QUE45yBvwyqdqKCADczrLt7=4W8X6BR+cy4PA@mail.gmail.com>
On 30 Aug 2015, at 18:36, Luke Diamand <luke@diamand.org> wrote:
Show 8 quoted lines
> On 30 August 2015 at 11:18, Lars Schneider <larsxschneider@gmail.com> wrote: >> Thanks for your feedback! >> >> I like the “handle big files” plugin kind of idea. However, I wonder if it makes sense to put more and more stuff into git-p4.py (>3000 LOC already). What do you think about splitting git-p4 into multiple files? > > I was wondering about that. I think for now, the simplicity of keeping > everything in one file is worth the slight extra pain. I don't imagine > that the big-file-handler code would be very large.
OK.
Show 9 quoted lines
> >> >> Regarding Python 3: >> Would you drop Python 2 support or do you want to support Python 2/3 in parallel? I would prefer the former… > > For quite some time we would need to support both; we can't just have > a release of git that one day breaks git-p4 for people stuck on Python > 2. But it might not be that hard to support both (though converting > all those print statements could be quite tiresome).
Agreed. However supporting both versions increases code complexity as well as testing effort. Would a compromise like the following work? We fork “git-p4.py” to “git-p4-python2.py” and just apply important bug fixes to that file. All new development happens on a Python 3 only git-p4.py.
Cheers, Lars