Re: BUG: [Cosmetic] Commiting a gerrit ChangeId before the commit hook was installed
- From
- Jerry Xinyu Zhao <xyzjerry-re5jqeeqqe8avxtiumwx3w@public.gmane.org>
- Date
- Jan 17, 2014, 23:24 UTC
- Message-ID
- <CAE3ttVgs=F2bWbx5qa=dp1kNzgc5djtB3r+2Qp6tvYv-iZKoCw@mail.gmail.com>
- In-Reply-To
- <CAC9meR+78_EvoqHNcuPyDKOZDjSsUngziGDa2aV1QDtOb8eOXw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
I think if you hadn't installed the commit hook for generating change ID, the commit indeed wouldn't have included a change ID, which is necessary for referencing the change when you submit a patch over it. There is nothing wrong with the message. git review tool will install the hook and add a change ID for you automatically(a new feature of recent git-review release).
On Fri, Jan 17, 2014 at 1:10 PM, Strainu <strainu10-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
Show 31 quoted lines
> 2014/1/17 Jonathan Nieder <jrnieder-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>: > > Hi, > > > > Strainu wrote: > > > >> strainu@emily:~/core> git review -f > >> Creating a git remote called "gerrit" that maps to: > >> ssh://strainu-pdwPRaUiG6tP5deQkEKVHGD2FQJk+8+b@public.gmane.org:29418/pywikibot/core.git > >> Your change was committed before the commit hook was installed. > >> Amending the commit to add a gerrit change id. > >> > >> At this point I ended the transaction, as I was confused by the last > >> message: I was afraid the ChangeId would have changed, causing the > >> patch to be attached to another review. > >> > >> I think git should not show this message if the change description > >> already has a change id > > > > This message doesn't come from git. It comes from the git-review > > tool (in git_review/cmd.py), so cc-ing the authors in case they > > have thoughts on that. > > Thanks for clarifying that. I'll log a bug on launchpad then. > > Strainu > > _______________________________________________ > OpenStack-Infra mailing list > OpenStack-Infra-ZwoEplunGu0gQVYkTtqAhEB+6BGkLq7r@public.gmane.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra >
_______________________________________________ OpenStack-Infra mailing list OpenStack-Infra-ZwoEplunGu0gQVYkTtqAhEB+6BGkLq7r@public.gmane.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra