Re: BUG: [Cosmetic] Commiting a gerrit ChangeId before the commit hook was installed

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 17, 2014, 20:41 UTC
Message-ID: <20140117204132.GB18964@google.com>
In-Reply-To: <CAC9meRKiR+60YaGiuCu4twEt6dyWksEjHSH8YPTEvmD=LoB=aw@mail.gmail.com>

Hi,

Strainu wrote:

Show 12 quoted lines

> strainu@emily:~/core> git review -f
> Creating a git remote called "gerrit" that maps to:
>         ssh://strainu@gerrit.wikimedia.org:29418/pywikibot/core.git
> Your change was committed before the commit hook was installed.
> Amending the commit to add a gerrit change id.
>
> At this point I ended the transaction, as I was confused by the last
> message: I was afraid the ChangeId would have changed, causing the
> patch to be attached to another review.
>
> I think git should not show this message if the change description
> already has a change id

This message doesn't come from git. It comes from the git-review tool (in git_review/cmd.py), so cc-ing the authors in case they have thoughts on that.

Thanks, Jonathan