Re: Is there any way to make hooks part of the repository?
- From
- Hilco Wijbenga <hilco.wijbenga@gmail.com>
- Date
- May 3, 2012, 17:05 UTC
- Message-ID
- <CAE1pOi39i4hg_bTuigq15ifuKtXVW7F-NukMP57E_4e=s0fMdQ@mail.gmail.com>
- In-Reply-To
- <87ipgdskpx.fsf@thomas.inf.ethz.ch>
On 3 May 2012 02:00, Thomas Rast <trast@student.ethz.ch> wrote:
Show 17 quoted lines
> Hilco Wijbenga <hilco.wijbenga@gmail.com> writes: > >>> Matthieu is *not* talking about auditing nastiness going into the >>> project's repository; he is talking is about a chance to audit whatever >>> comes from the project's repository that *could* potentially contain some >>> nastiness before it causes harm to your working environment. In other >>> words, not *having* to trust what is in the project's repository, but >>> having a way to verify. >> >> Perhaps these automatic hooks should only be applicable for "outgoing" >> changes like commit and push? That way you can review the hooks before >> they run but you still have a chance to prevent developer errors from >> getting to the server/other people (which is really all I care about, >> I am looking for a way to protect developers from making silly >> mistakes). > > Shouldn't those checks be made server-side with a pre-receive hook?
Firstly, see my original email: we have no such access to the server. Secondly, (now that I've thought about it a bit more), it makes more sense to do it on the "client" instead of having the server do all the work for everybody. (Fail early, fail fast.)