git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Is there any way to make hooks part of the repository?

From
Junio C Hamano <gitster@pobox.com>
Date
May 2, 2012, 19:27 UTC
Message-ID
<7v1un2idt0.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CAE1pOi3RZ+x7YcVZ-dLt70=wwRsvY9D6GQR-T+JZ9S7x8CFjPw@mail.gmail.com>
Hilco Wijbenga <hilco.wijbenga@gmail.com> writes:
Show 10 quoted lines
> On 1 May 2012 23:38, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:
> ...
>> Yes, but at least, you have the opportunity to examine the other places
>> before they are ran. Hooks would be really, really nasty security-wise.
>> For example, "git clone" does a checkout, so should probably run the
>> checkout hooks.
>
> There is (or, rather, should be) absolutely no difference between code
> changes and hook changes. Both would go through the same review
> process.

Matthieu is *not* talking about auditing nastiness going into the project's repository; he is talking is about a chance to audit whatever comes from the project's repository that *could* potentially contain some nastiness before it causes harm to your working environment. In other words, not *having* to trust what is in the project's repository, but having a way to verify.

Read what he wrote again with that in mind, and you will understand his point.

Previous: Hilco WijbengaNext: Hilco Wijbenga
Message 14 of 18 in “Is there any way to make hooks part of the repository?”
  1. Hilco WijbengaMay 1, 2012
  2. Junio C HamanoMay 1, 2012
  3. Randal L. SchwartzMay 1, 2012
  4. Junio C HamanoMay 1, 2012
  5. Hilco WijbengaMay 1, 2012
  6. PJ WeisbergMay 1, 2012
  7. Hilco WijbengaMay 1, 2012
  8. Nathan GrayMay 2, 2012
  9. Hilco WijbengaMay 2, 2012
  10. Hilco WijbengaMay 1, 2012
  11. Hilco WijbengaMay 1, 2012
  12. Matthieu MoyMay 2, 2012
  13. Hilco WijbengaMay 2, 2012
  14. Junio C HamanoMay 2, 2012
  15. Hilco WijbengaMay 2, 2012
  16. Thomas RastMay 3, 2012
  17. Hilco WijbengaMay 3, 2012
  18. Johan HerlandMay 4, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.