Re: [PATCH v2 1/1] Allow reworking with a file after deciding on all its hunks

From: Samuel Abraham <abrahamadekunle50@gmail.com>
Date: Jan 30, 2026, 17:36 UTC
Message-ID: <CADYq+faOK=VQarMMyxD9OCTMrM__o0=87Bm0MSxFkSfYV7v7nw@mail.gmail.com>
In-Reply-To: <xmqq8qdf83nu.fsf@gitster.g>

On Fri, Jan 30, 2026 at 5:29 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

>
> Samuel Abraham <abrahamadekunle50@gmail.com> writes:
>
> > Hello Junio, thank you for your review.
> > Here I explain my decision to move the "git apply" in patch_update_file()
> > to the caller.
> >
> > Does it sound like a valid reason to make the move?
>
> I am not sure, but as long as this is an optional feature, users can
> choose not to opt in if they do not like the new "all or none"
> semantics, I guess.
>
> Thanks.

Okay thank you. I will work on making it an optional feature

Abraham

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.