git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Documentation/MyFirstObjectWalk: add #include "trace.h" to use trace_printf()

From
Vinayak Dev <vinayakdev.sci@gmail.com>
Date
Jun 29, 2023, 16:05 UTC
Message-ID
<CADE8Naq5W3Bn=gwV7W-xMvYOMMRO=ZY9Ly6im4Rb_qFjMWTbTg@mail.gmail.com>

Hey there! I was looking through Documentation/MyFirstObjectWalk.txt, and upon building the branch containing the given code, I find that I get the error that C99 does not allow implicit function declaration where trace_printf() is encountered. However, upon including trace.h the error disappears, and the build proceeds just fine.

I did put DEVELOPER=1 in config.mak before building, but it doesn't seem to work.

Is the error pointing to a problem, or am I doing something wrong? If it is the former, I would be very happy to send a patch fixing this.

Thanks a lot! Vinayak

Next: Emily Shaffer
Message 1 of 10 in “Documentation/MyFirstObjectWalk: add #include "trace.h" to use trace_printf()”
  1. Vinayak DevJun 29, 2023
  2. Emily ShafferJun 29, 2023
  3. Emily ShafferJun 29, 2023
  4. Vinayak DevJun 29, 2023
  5. Emily ShafferJun 29, 2023
  6. Vinayak DevJun 30, 2023
  7. Vinayak DevJun 30, 2023
  8. Junio C HamanoJun 29, 2023
  9. Emily ShafferJun 29, 2023
  10. Junio C HamanoJun 30, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.