git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Documentation/MyFirstObjectWalk: add #include "trace.h" to use trace_printf()

From
Vinayak Dev <vinayakdev.sci@gmail.com>
Date
Jun 30, 2023, 15:39 UTC
Message-ID
<CADE8NapQK2ouy4YDQA+3NNkUn_EegkSBQCtDfcSCVGmZvVufXg@mail.gmail.com>
In-Reply-To
<CADE8NaqSn7DvvBHzLhGdWwZtwK+sxoKnVWo_G26P30p_WnVXJg@mail.gmail.com>

Hi! I pulled down walken.c from https://github.com/nasamuffin/git/tree/revwalk and was able to fix the broken code. I also fixed Documentation/MyFirstObjectWalk.txt and have accordingly pushed all the changes to my fork of git:

https://github.com/vinayakdsci/git/tree/revwalk-fixed

I had to remove init_walken_defaults() as I could not trace the function init_grep_defaults() which I think has been removed since you wrote the tutorial. I also didn't find a mention of init_grep_defaults() in the tutorial, so maybe that is alright. Also, struct list_objects_filter_options is included inside of rev_info, so I don't think it requires initialisation any more.

It would be great if you are able to use this branch to rewrite your own!

Thanks a lot! Vinayak

Previous: Vinayak DevNext: Junio C Hamano
Message 7 of 10 in “Documentation/MyFirstObjectWalk: add #include "trace.h" to use trace_printf()”
  1. Vinayak DevJun 29, 2023
  2. Emily ShafferJun 29, 2023
  3. Emily ShafferJun 29, 2023
  4. Vinayak DevJun 29, 2023
  5. Emily ShafferJun 29, 2023
  6. Vinayak DevJun 30, 2023
  7. Vinayak DevJun 30, 2023
  8. Junio C HamanoJun 29, 2023
  9. Emily ShafferJun 29, 2023
  10. Junio C HamanoJun 30, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.