git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 2/3] Makefile: add Perl runtime prefix support

From
Daniel Jacques <dnj@google.com>
Date
Mar 19, 2018, 22:07 UTC
Message-ID
<CAD1RUU-emF0n2Qwvs_A4GqZ=CVZmfoRWoSAkr7J6yeov7zfp4Q@mail.gmail.com>
In-Reply-To
<CAN0heSpu4Lv9P+zzKPgJe3nx+J20Yex9is8SCztKobLc5ZfWCA@mail.gmail.com>
On Mon, Mar 19, 2018 at 5:32 PM Martin Ågren <martin.agren@gmail.com> wrote:
Show 6 quoted lines
> This commit message mentions RUNTIME_PREFIX_PERL twice, but there is no
> use of RUNTIME_PREFIX_PERL in the actual diffs (patches 1-3/3). Should
> it be s/_PERL//? Your cover letter hints as much under "Changes in v6
> from v5". And "Add a new Makefile flag ..." would need some more
> rewriting since this patch rather expands the scope of the existing
> flag?

Thanks for pointing this out - the two were separate flags in my original patch set because I wanted to minimize the scope of impact; however, I have since received advice and buy-in on converging them and RUNTIME_PREFIX_PERL functionality was merged underneath of RUNTIME_PREFIX in this latest patch set.

I'll update the commit message!
Previous: Martin ÅgrenNext: Dan Jacques
Message 14 of 21 in “RUNTIME_PREFIX relocatable Git”
  1. 0/3 RUNTIME_PREFIX relocatable GitDan Jacques, Mar 19, 2018
  2. 1/3 Makefile: generate Perl header from template fileDan Jacques, Mar 19, 2018
  3. Eric SunshineMar 19, 2018
  4. 2/3 Makefile: add Perl runtime prefix supportDan Jacques, Mar 19, 2018
  5. Junio C HamanoMar 19, 2018
  6. Daniel JacquesMar 19, 2018
  7. Ævar Arnfjörð BjarmasonMar 19, 2018
  8. Daniel JacquesMar 19, 2018
  9. Daniel JacquesMar 19, 2018
  10. Junio C HamanoMar 19, 2018
  11. Ævar Arnfjörð BjarmasonMar 19, 2018
  12. Daniel JacquesMar 19, 2018
  13. Martin ÅgrenMar 19, 2018
  14. Daniel JacquesMar 19, 2018
  15. 3/3 exec_cmd: RUNTIME_PREFIX on some POSIX systemsDan Jacques, Mar 19, 2018
  16. Junio C HamanoMar 19, 2018
  17. Daniel JacquesMar 19, 2018
  18. Ævar Arnfjörð BjarmasonMar 19, 2018
  19. Daniel JacquesMar 19, 2018
  20. Junio C HamanoMar 19, 2018
  21. Ævar Arnfjörð BjarmasonMar 19, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.