Re: [Outreachy PATCH v3 1/2] gpg-interface: replace strbuf_split*() with string_list_split*()
- From
Bello Olamide <belkid98@gmail.com>
- Date
- Oct 20, 2025, 18:25 UTC
- Message-ID
- <CAD=f0L_4O9oLxUToLn3QwDopFCnYAKQwBPOXwb+xuPkqXh=p1A@mail.gmail.com>
- In-Reply-To
- <4bd36d2e-7629-41bf-9731-493cf3bd151a@app.fastmail.com>
On Mon, 20 Oct 2025 at 17:46, Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com> wrote:
Show 6 quoted lines
> > On Sun, Oct 19, 2025, at 14:07, Olamide Caleb Bello wrote: > >[snip] > > > > Signed-off-by: Olamide Caleb Bello <belkid98@gmail.com> >
Hello Kristoffer, Thank you for your review.
Show 10 quoted lines
> Signoff should go at the end of the commit message. You’re saying that > you are signing off on the changes as well as what was written in the > commit message before that line. If I later add mine: > > Signed-off-by: Olamide Caleb Bello <belkid98@gmail.com> > Signed-off-by: ME > > I would be saying that I am signing off on the changes as well as the > previous lines in the commit message, including that line that you > wrote.
Please just to make sure I get you correctly, you are saying the Signoff should be the last thing in the commit message.
Like I should put it below the other tags so that if you also want to add yours, It can easily go below mine and it would mean you are signing off on the changes including my own Signoff?
> > > Reported-by: Junio Hamano <gitster@pobox.com> > > Helped-by: Christian Couder <christian.couder@gmail.com> > > Helped-by: Junio Hamano <gitster@pobox.com>
It should go below here instead?
Thank you.
Bello