Re: [Outreachy PATCH v3 1/2] gpg-interface: replace strbuf_split() with string_list_split()

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Oct 20, 2025, 16:45 UTC
Message-ID: <4bd36d2e-7629-41bf-9731-493cf3bd151a@app.fastmail.com>
In-Reply-To: <7da4fded535984faea52d5f88793d3c8e47c0091.1760869186.git.belkid98@gmail.com>

On Sun, Oct 19, 2025, at 14:07, Olamide Caleb Bello wrote:

>[snip]
>
> Signed-off-by: Olamide Caleb Bello <belkid98@gmail.com>

Signoff should go at the end of the commit message. You’re saying that you are signing off on the changes as well as what was written in the commit message before that line. If I later add mine:

    Signed-off-by: Olamide Caleb Bello <belkid98@gmail.com>
    Signed-off-by: ME

I would be saying that I am signing off on the changes as well as the previous lines in the commit message, including that line that you wrote.

Show 7 quoted lines

> Reported-by: Junio Hamano <gitster@pobox.com>
> Helped-by: Christian Couder <christian.couder@gmail.com>
> Helped-by: Junio Hamano <gitster@pobox.com>
> ---
>  gpg-interface.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>[snip]

Re: [Outreachy PATCH v3 1/2] gpg-interface: replace strbuf_split*() with string_list_split*()

Re: [Outreachy PATCH v3 1/2] gpg-interface: replace strbuf_split() with string_list_split()