Re: [PATCH] pretty: Fix bug in truncation support for %>, %< and %><

From: Duy Nguyen <pclouds@gmail.com>
Date: Apr 27, 2013, 23:59 UTC
Message-ID: <CACsJy8Dx2tKdQDLw9=i1aM6=uqVBvHYpzq-q+rQE-e7-oJTRcg@mail.gmail.com>
In-Reply-To: <517C2A68.4030802@ramsay1.demon.co.uk>

On Sun, Apr 28, 2013 at 2:43 AM, Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:

Show 11 quoted lines

> The truncation support was implemented with the assistance of a
> new strbuf function (strbuf_utf8_replace). This function contains
> the following code:
>
>        strbuf_attach(sb_src, strbuf_detach(&sb_dst, NULL),
>                      sb_dst.len, sb_dst.alloc);
>
> Unfortunately, this code is subject to unspecified behaviour. In
> particular, the order of evaluation of the argument expressions
> (along with the associated side effects) is not specified by the
> C standard.

Thanks for noticing and fixing it. What compiler did you use by the way? -- Duy