git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC 02/11] remote.c: add infrastructure for parsing --prune options

From
Duy Nguyen <pclouds@gmail.com>
Date
Dec 4, 2013, 12:57 UTC
Message-ID
<CACsJy8DwfXPn6vJXuMyNP7W3tKe2w_mzxdw53kL=-T+0YU5wCw@mail.gmail.com>
In-Reply-To
<1386135890-13954-3-git-send-email-mhagger@alum.mit.edu>
On Wed, Dec 4, 2013 at 12:44 PM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
Show 9 quoted lines
> +void argv_push_prune_option(struct argv_array *argv,
> +                           struct prune_option *prune_option)
> +{
> +       if (prune_option->prune != -1)
> +               argv_array_pushf(argv,
> +                                prune_option->prune
> +                                ? "--prune"
> +                                : "--no-prune");
> +}
Nit. I think argv_array_push() is enough for this case?
-- 
Duy
Previous: Michael HaggertyNext: Michael Haggerty
Message 4 of 15 in “[RFC 00/11] Make reference pruning more configurable”
  1. Michael HaggertyDec 4, 2013
  2. 01/11 get_stale_heads(): allow limiting to refname patternsMichael Haggerty, Dec 4, 2013
  3. 02/11 remote.c: add infrastructure for parsing --prune optionsMichael Haggerty, Dec 4, 2013
  4. Duy NguyenDec 4, 2013
  5. Michael HaggertyDec 4, 2013
  6. 03/11 fetch: use the new functions for handling --prune optionsMichael Haggerty, Dec 4, 2013
  7. 04/11 remote: use the new functions for handling --prune optionsMichael Haggerty, Dec 4, 2013
  8. 05/11 remote.c: add infrastructure to handle --prune=<pattern>Michael Haggerty, Dec 4, 2013
  9. 06/11 fetch --prune: allow refname patterns to be specifiedMichael Haggerty, Dec 4, 2013
  10. 07/11 remote update --prune: allow refname patterns to be specifiedMichael Haggerty, Dec 4, 2013
  11. 08/11 string_list_append_list(): new functionMichael Haggerty, Dec 4, 2013
  12. 09/11 remote prune: allow --prune=<pattern> optionsMichael Haggerty, Dec 4, 2013
  13. 10/11 remote show: allow --prune=<pattern> optionsMichael Haggerty, Dec 4, 2013
  14. 11/11 remote: allow prune patterns to be configuredMichael Haggerty, Dec 4, 2013
  15. Junio C HamanoDec 4, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.