Re: [RFC 02/11] remote.c: add infrastructure for parsing --prune options

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Dec 4, 2013, 17:04 UTC
Message-ID: <529F60A6.90309@alum.mit.edu>
In-Reply-To: <CACsJy8DwfXPn6vJXuMyNP7W3tKe2w_mzxdw53kL=-T+0YU5wCw@mail.gmail.com>

On 12/04/2013 01:57 PM, Duy Nguyen wrote:

Show 12 quoted lines

> On Wed, Dec 4, 2013 at 12:44 PM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
>> +void argv_push_prune_option(struct argv_array *argv,
>> +                           struct prune_option *prune_option)
>> +{
>> +       if (prune_option->prune != -1)
>> +               argv_array_pushf(argv,
>> +                                prune_option->prune
>> +                                ? "--prune"
>> +                                : "--no-prune");
>> +}
> 
> Nit. I think argv_array_push() is enough for this case?

Yes, you're right.  Thanks for noticing.

If people want this patch series I will fix the problem in the next round.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/