Re: [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings

From: Duy Nguyen <pclouds@gmail.com>
Date: Feb 26, 2016, 09:33 UTC
Message-ID: <CACsJy8Dc1dHp7kGgz_pY1uoXum-k3gnzD0AHFsaLQzuZihUKcw@mail.gmail.com>
In-Reply-To: <17AFC0E6-FC83-4BD4-9C19-43A6B9103866@gmail.com>

On Fri, Feb 26, 2016 at 4:30 PM, Lars Schneider <larsxschneider@gmail.com> wrote:

Show 22 quoted lines

>
>> On 26 Feb 2016, at 10:26, Duy Nguyen <pclouds@gmail.com> wrote:
>>
>> On Thu, Feb 25, 2016 at 3:42 PM,  <larsxschneider@gmail.com> wrote:
>>> +ifdef DEVELOPER
>>> +       CFLAGS +=       -Werror \
>>> +                               -Wdeclaration-after-statement \
>>> +                               -Wno-format-zero-length \
>>> +                               -Wold-style-definition \
>>> +                               -Woverflow \
>>> +                               -Wpointer-arith \
>>> +                               -Wstrict-prototypes \
>>> +                               -Wunused \
>>> +                               -Wvla
>>
>> With the exception of $(SCRIPTS) in Makefile, I think we prefer to
>> avoid \ and have one addition per statement
>>
> I guessed that because I actually looked through the makefile to find how you deal with line
> brakes. The problem here was that this line gets really long and then it is hard to see what
> warnings are enabled.
> Would you be OK with using \ for readability here?

Probably misunderstanding. I meant something like this

CFLAGS += -Werror CFLAGS += -Wdecl.. CFLAGS += -Wno-form..

-- 
Duy