Re: [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings

From: Duy Nguyen <pclouds@gmail.com>
Date: Feb 28, 2016, 10:49 UTC
Message-ID: <CACsJy8BA49owewikfa_LpMQ5A+2DqWLtMUPck7qRrSzv+BQU_g@mail.gmail.com>
In-Reply-To: <47DA71B9-5A00-48E4-B7A8-6C678F597627@gmail.com>

On Sun, Feb 28, 2016 at 5:35 PM, Lars Schneider <larsxschneider@gmail.com> wrote:

Show 9 quoted lines

> On 26 Feb 2016, at 10:33, Duy Nguyen <pclouds@gmail.com> wrote:
>> Probably misunderstanding. I meant something like this
>>
>> CFLAGS += -Werror
>> CFLAGS += -Wdecl..
>> CFLAGS += -Wno-form..
>
> Oh. I just realized the patch made it already into master. Do you think I should submit
> a follow up patch?

If it's already in, it's probably not worth changing it again.

> I also wonder, do you see an advantage of one style over the other or do you want me to change it for consistency?

If you add a new option at the end, then you only add one new line. You need to add '\\' to the last line with the other format. It also makes re-sorting a bit easier (but this point is not applicable here because we need some special sort order, where we ignore "no-" part).

-- 
Duy