Re: [PATCH 5/5] versioncmp: cope with common leading parts in versionsort.prereleaseSuffix
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Sep 9, 2016, 10:43 UTC
- Message-ID
- <CACsJy8DZtAOL9OA_6eqKN7bfS2up+LLEYOWDg=Nh0Quy3coAVQ@mail.gmail.com>
- In-Reply-To
- <20160907174841.Horde.Ru1LBEeLKomznlWVG-ZnS-Q@webmail.informatik.kit.edu>
On Wed, Sep 7, 2016 at 10:48 PM, SZEDER Gábor <szeder@ira.uka.de> wrote:
Show 23 quoted lines
> Now, while I believe this is the right thing to do to fix this bug, > there is a corner case, where multiple configured prerelease suffixes > might match the same tagname: > > $ git config --get-all versionsort.prereleaseSuffix > -bar > -baz > -foo-bar > $ ~/src/git/git tag -l --sort=version:refname > v1.0-foo-bar > v1.0-foo-baz > > I.e. when comparing these two tags, both "-bar" and "-foo-bar" would > match "v1.0-foo-bar", and as "-bar" comes first in the config file, > it wins, and "v1.0-foo-bar" is ordered first. An argument could be > made to prefer longer matches, in which case "v1.0-foo-bar" would be > ordered according to "-foo-bar", i.e. as second. However, I don't > know what that argument could be, to me neither behavior is better > than the other, but the implementation of the "longest match counts" > would certainly be more complicated. > > The argument I would make is that this is a pathological corner case > that doesn't worth worrying about.
Maybe we should keep a note about this in config.txt? If it's not worth bothering/scaring the users about, I suggest you keep this in the commit message.
-- Duy