Re: 2.10.0: multiple versionsort.prereleasesuffix buggy?

From: Jeff King <peff@peff.net>
Date: Sep 5, 2016, 23:21 UTC
Message-ID: <20160905232145.fr46rgfb66eeymwp@sigill.intra.peff.net>
In-Reply-To: <beba7c55-3f18-66a2-acd9-77f2a5cc55a7@conversionready.com>

On Tue, Sep 06, 2016 at 01:42:28AM +0300, Leho Kraav (Conversion Ready) wrote:

Show 18 quoted lines

> Here's the testing tree https://github.com/woothemes/woocommerce
> 
> .git/config has:
> 
> [versionsort]
> 
> 
>     prereleasesuffix = -beta
>     prereleasesuffix = -RC
> 
> $ git tag -l --sort=version:refname
> [...]
> 2.6.0-RC1
> 2.6.0-RC2
> 2.6.0-beta-1
> 2.6.0-beta-2
> 2.6.0-beta-3
> 2.6.0-beta-4

So that seems wrong. Even weirder, if I set _only_ "-beta", I get:

  $ git tag -l --sort=version:refname | grep -v ^2.6.0
  2.6.0-beta-2
  2.6.0-beta-3
  2.6.0-beta-4
  2.6.0
  2.6.0-RC1
  2.6.0-RC2
  2.6.0-beta-1

Umm...what? beta-1 is sorted away from its companions? That's weird.

I wondered if the presence of "-" after the suffix ("beta-1" rather than "beta1") would matter. It looks like that shouldn't matter, though; it's purely doing a prefix match on "do these names differ at a prerelease suffix".

But something certainly seems wrong.

-Peff