Re: [PATCH v2 00/11] git worktree (re)move

From: Duy Nguyen <pclouds@gmail.com>
Date: Nov 30, 2016, 00:09 UTC
Message-ID: <CACsJy8DNJw66n+h5uKtxGHibKJRFOQP5=V35gKo3bRarx2vDsA@mail.gmail.com>
In-Reply-To: <c73ec2ee-eed0-414c-63a1-a1bd5c864cef@kdbg.org>

On Wed, Nov 30, 2016 at 4:14 AM, Johannes Sixt <j6t@kdbg.org> wrote:

Show 20 quoted lines

>> diff --git a/copy.c b/copy.c
>> index 4de6a11..b232aec 100644
>> --- a/copy.c
>> +++ b/copy.c
>> @@ -65,3 +65,9 @@ int copy_file_with_time(const char *dst, const char
>> *src, int mode)
>>                 return copy_times(dst, src);
>>         return status;
>>  }
>> +
>> +int copy_dir_recursively(const char *dst, const char *src)
>> +{
>> +       errno = ENOSYS;
>> +       return -1;
>> +}
>
>
> An error message "cannot move directories across devices" or something would
> be preferable over "Function not implemented", of course. Or did you mean to
> set errno = EXDEV?

The exact message is not super important right now. Though I'm thinking of adding move_directory() that is a wrapper of rename(). We can die("cannot move directories across devices") then and hopefully be able to move across devices at some point.

-- 
Duy