Re: [PATCH v9 03/19] index-helper: new daemon for caching index and related stuff

From: Duy Nguyen <pclouds@gmail.com>
Date: May 10, 2016, 10:31 UTC
Message-ID: <CACsJy8DLmcxmw5aGT3FszccW3UNujBcr8uZzJuJoWxvASKnpPg@mail.gmail.com>
In-Reply-To: <20160510101315.32403-1-szeder@ira.uka.de>

This reminds me, we need to update command-list.txt as well. I guess it belongs to purehelpers? Back to the patch..

On Tue, May 10, 2016 at 5:13 PM, SZEDER Gábor <szeder@ira.uka.de> wrote:

> This patch adds a new plumbing command, which then will show up in
> completion after 'git <TAB>'.  Could you please squash in this
> oneliner to exclude index-helper from porcelain commands in the
> completion script?

I don't think the user should run this command explicitly a lot. Usually it should be run automatically (with config key indexhelper.autorun) and die when idle for some time. You just don't care about it (until performance degrades and you have to investigate). Occasionally you may have to "git index-helper --kill". Is there any other reason it should be run often enough to justify this change?

Show 21 quoted lines

>
>
> ---
>  contrib/completion/git-completion.bash | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 34024754d929..9264ab919a6a 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -684,6 +684,7 @@ __git_list_porcelain_commands ()
>                 for-each-ref)     : plumbing;;
>                 hash-object)      : plumbing;;
>                 http-*)           : transport;;
> +               index-helper)     : plumbing;;
>                 index-pack)       : plumbing;;
>                 init-db)          : deprecated;;
>                 local-fetch)      : plumbing;;
> --
> 2.8.2.356.ge684b1d
>

-- 
Duy