git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v9 02/19] read-cache: allow to keep mmap'd memory after reading

From
David Turner <dturner@twopensource.com>
Date
May 9, 2016, 20:48 UTC
Message-ID
<1462826929-7567-3-git-send-email-dturner@twopensource.com>
In-Reply-To
<1462826929-7567-1-git-send-email-dturner@twopensource.com>
From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>

Later, we will introduce git index-helper to share this memory with other git processes.

We only unmap it when we discard the index (although the kernel may of course choose to page it out).

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: David Turner <dturner@twopensource.com>
---
 cache.h      |  3 +++
 read-cache.c | 13 ++++++++++++-
 2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/cache.h b/cache.h
index b829410..4180e2b 100644
--- a/cache.h
+++ b/cache.h
@@ -333,11 +333,14 @@ struct index_state {
 	struct split_index *split_index;
 	struct cache_time timestamp;
 	unsigned name_hash_initialized : 1,
+		 keep_mmap : 1,
 		 initialized : 1;
 	struct hashmap name_hash;
 	struct hashmap dir_hash;
 	unsigned char sha1[20];
 	struct untracked_cache *untracked;
+	void *mmap;
+	size_t mmap_size;
 };
 
 extern struct index_state the_index;
diff --git a/read-cache.c b/read-cache.c
index 16cc487..3cb0ec3 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -1574,6 +1574,10 @@ int do_read_index(struct index_state *istate, const char *path, int must_exist)
 	mmap = xmmap(NULL, mmap_size, PROT_READ, MAP_PRIVATE, fd, 0);
 	if (mmap == MAP_FAILED)
 		die_errno("unable to map index file");
+	if (istate->keep_mmap) {
+		istate->mmap = mmap;
+		istate->mmap_size = mmap_size;
+	}
 	close(fd);
 
 	hdr = mmap;
@@ -1626,11 +1630,13 @@ int do_read_index(struct index_state *istate, const char *path, int must_exist)
 		src_offset += 8;
 		src_offset += extsize;
 	}
-	munmap(mmap, mmap_size);
+	if (!istate->keep_mmap)
+		munmap(mmap, mmap_size);
 	return istate->cache_nr;
 
 unmap:
 	munmap(mmap, mmap_size);
+	istate->mmap = NULL;
 	die("index file corrupt");
 }
 
@@ -1655,6 +1661,7 @@ int read_index_from(struct index_state *istate, const char *path)
 		discard_index(split_index->base);
 	else
 		split_index->base = xcalloc(1, sizeof(*split_index->base));
+	split_index->base->keep_mmap = istate->keep_mmap;
 	ret = do_read_index(split_index->base,
 			    git_path("sharedindex.%s",
 				     sha1_to_hex(split_index->base_sha1)), 1);
@@ -1698,6 +1705,10 @@ int discard_index(struct index_state *istate)
 	free(istate->cache);
 	istate->cache = NULL;
 	istate->cache_alloc = 0;
+	if (istate->keep_mmap && istate->mmap) {
+		munmap(istate->mmap, istate->mmap_size);
+		istate->mmap = NULL;
+	}
 	discard_split_index(istate);
 	free_untracked_cache(istate->untracked);
 	istate->untracked = NULL;
-- 
2.4.2.767.g62658d5-twtrsrc
Previous: David TurnerNext: David Turner
Message 3 of 39 in “index-helper/watchman”
  1. 00/19 index-helper/watchmanDavid Turner, May 9, 2016
  2. 01/19 read-cache.c: fix constness of verify_hdr()David Turner, May 9, 2016
  3. 02/19 read-cache: allow to keep mmap'd memory after readingDavid Turner, May 9, 2016
  4. 03/19 index-helper: new daemon for caching index and related stuffDavid Turner, May 9, 2016
  5. SZEDER GáborMay 10, 2016
  6. Duy NguyenMay 10, 2016
  7. SZEDER GáborMay 10, 2016
  8. Duy NguyenMay 10, 2016
  9. David TurnerMay 10, 2016
  10. 04/19 index-helper: add --strictDavid Turner, May 9, 2016
  11. 05/19 index-helper: log warningsDavid Turner, May 9, 2016
  12. 06/19 daemonize(): set a flag before exiting the main processDavid Turner, May 9, 2016
  13. 07/19 index-helper: add --detachDavid Turner, May 9, 2016
  14. 08/19 read-cache: add watchman 'WAMA' extensionDavid Turner, May 9, 2016
  15. 09/19 watchman: support watchman to reduce index refresh costDavid Turner, May 9, 2016
  16. 10/19 index-helper: use watchman to avoid refreshing index with lstat()David Turner, May 9, 2016
  17. 11/19 update-index: enable/disable watchman supportDavid Turner, May 9, 2016
  18. 12/19 unpack-trees: preserve index extensionsDavid Turner, May 9, 2016
  19. 13/19 watchman: add a config option to enable the extensionDavid Turner, May 9, 2016
  20. 14/19 index-helper: kill modeDavid Turner, May 9, 2016
  21. 15/19 index-helper: don't run if already runningDavid Turner, May 9, 2016
  22. 16/19 index-helper: autorun modeDavid Turner, May 9, 2016
  23. 17/19 index-helper: optionally automatically runDavid Turner, May 9, 2016
  24. 18/19 trace: measure where the time is spent in the index-heavy operationsDavid Turner, May 9, 2016
  25. 19/19 untracked-cache: config optionDavid Turner, May 9, 2016
  26. Junio C HamanoMay 9, 2016
  27. David TurnerMay 9, 2016
  28. Junio C HamanoMay 9, 2016
  29. Junio C HamanoMay 9, 2016
  30. David TurnerMay 9, 2016
  31. Ramsay JonesMay 9, 2016
  32. Duy NguyenMay 10, 2016
  33. Duy NguyenMay 10, 2016
  34. Dennis KaarsemakerMay 10, 2016
  35. Dennis KaarsemakerMay 10, 2016
  36. Dennis KaarsemakerMay 10, 2016
  37. Ramsay JonesMay 10, 2016
  38. Junio C HamanoMay 10, 2016
  39. Ramsay JonesMay 10, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.