Re: Output from "git blame A..B -- path" for the bottom commit is misleading
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- May 10, 2014, 13:45 UTC
- Message-ID
- <CACsJy8DKSsp_Y+KosFPUP5UobiiS2GjdgOug8_x+d6iLec6HbQ@mail.gmail.com>
- In-Reply-To
- <87zjiro856.fsf@fencepost.gnu.org>
On Fri, May 9, 2014 at 12:04 PM, David Kastrup <dak@gnu.org> wrote:
Show 16 quoted lines
> Jeff King <peff@peff.net> writes: > >> I'd actually be inclined to say the opposite of what Junio is saying >> there: that "-b" should blank the author field as well as the commit >> sha1. I'd even go so far as to say that "-b" should probably be the >> default when boundary commits are in use. I cannot think of a time when >> I have found the boundary information useful, and the IMHO the output >> above is less confusing than what we produce now. But I admit I haven't >> thought very hard on it. > > Arguably if the user explicitly limited the range, he knows what he's > looking at. Admittedly, I don't know offhand which options _will_ > produce boundary commit indications: there may be some without explicit > range limitation, and we might also be talking about limiting through > shallow repos (git blame on a shallow repo is probably a bad idea in the > first place, but anyway).
No it's not. The idea of shallow repos is to work like a normal repo (most of the time at least). Excluding git-blame from shallow repos is a bad idea. Luckily it's not hard to detect shallow boundaries: if a commit has no parents and lookup_commit_graft() returns -1, then that's it.
-- Duy