Re: [PATCH] git help: promote 'git help -av'

From: Duy Nguyen <pclouds@gmail.com>
Date: Sep 26, 2018, 16:18 UTC
Message-ID: <CACsJy8DCdwAre9dhwwC_5STNq_BuWahv-9Hoim+YUtVssJbzdQ@mail.gmail.com>
In-Reply-To: <20180925205446.GB21956@sigill.intra.peff.net>

On Tue, Sep 25, 2018 at 10:54 PM Jeff King <peff@peff.net> wrote:

> Mentioning aliases seems reasonable to me. The definitions of some of
> mine are pretty nasty bits of shell, but I guess that people either
> don't have any ugly aliases, or are comfortable enough with them that
> they won't be scared away. :)

I have one with a very long pretty format for git-log. Well, you wrote your aliases you learn to live with them :) We could certainly cut too long aliased commands to keep the listing pretty, but I don't think we should do that until somebody asks for it.

Show 13 quoted lines

> > -- 8< --
> > @@ -53,7 +52,6 @@ static struct option builtin_help_options[] = {
> >                       HELP_FORMAT_WEB),
> >       OPT_SET_INT('i', "info", &help_format, N_("show info page"),
> >                       HELP_FORMAT_INFO),
> > -     OPT__VERBOSE(&verbose, N_("print command description")),
> >       OPT_END(),
> >  };
>
> Would we want to continue respecting "-v" as a noop? I admit I did not
> even know it existed until this thread, but if people have trained
> themselves to run "git help -av", we should probably continue to give
> them this output.

-v was recently added just for the new "help -a" in May 2018. I think it's ok to get rid of it. Memory muscles probably take a couple more months to kick in.

-- 
Duy