Re: [PATCH] git help: promote 'git help -av'

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 28, 2018, 17:49 UTC
Message-ID: <20180928174946.GE23652@syl>
In-Reply-To: <xmqqefddeg90.fsf@gitster-ct.c.googlers.com>

On Fri, Sep 28, 2018 at 09:30:51AM -0700, Junio C Hamano wrote:

Show 22 quoted lines

> Taylor Blau <me@ttaylorr.com> writes:
>
> > On Wed, Sep 26, 2018 at 10:28:31AM -0700, Junio C Hamano wrote:
> >> Duy Nguyen <pclouds@gmail.com> writes:
> >>
> >> > Here's the patch that adds that external commands and aliases
> >> > sections. I feel that external commands section is definitely good to
> >> > have even if we don't replace "help -a". Aliases are more
> >> > subjective...
> >>
> >> I didn't apply this (so I didn't try running it), but a quick
> >> eyeballing tells me that the listing of external commands in -av
> >> output done in this patch seems reasonable.
> >>
> >> I do not think removing "-v" and making the current "help -a" output
> >> unavailable is a wise idea, though.
> >
> > I think that your point about having to react in a split-second in order
> > to ^C before we open the manual page for a command is a good one. So, I
> > agree with this.
>
> Responding to a wrong thread?

Ah, I certainly am. Thanks for catching my mistake :-).

> I thought "now I need ^C within a handful of deciseconds if I want
> only alias?" was not about the change to make "-v" default when
> "help -a" is asked, but about what to do with "git foo --help" that
> only gives "foo is aliased to ...".

Thanks, Taylor