Re: [PATCH v2 09/19] ls-files.c: use index api

From: Duy Nguyen <pclouds@gmail.com>
Date: Jul 14, 2013, 03:39 UTC
Message-ID: <CACsJy8DA=AD8=_kVYLNMS53fb8QwqKG4=8fA1cYAQBTn1gcj0Q@mail.gmail.com>
In-Reply-To: <1373650024-3001-10-git-send-email-t.gummerer@gmail.com>

On Sat, Jul 13, 2013 at 12:26 AM, Thomas Gummerer <t.gummerer@gmail.com> wrote:

Show 7 quoted lines

> +       if (!with_tree) {
> +               memset(opts, 0, sizeof(*opts));
> +               opts->pathspec = &pathspec_struct;
> +               opts->read_staged = 1;
> +               if (show_resolve_undo)
> +                       opts->read_resolve_undo = 1;
> +               read_cache_filtered(opts);

So you load partial index here.

Show 6 quoted lines

> +       } else {
> +               read_cache();
> +       }
> +       /* be nice with submodule paths ending in a slash */
> +       if (pathspec)
> +               strip_trailing_slash_from_submodules();

Then strip_trailing_slash_from_submodules will attempt to convert pathspec "foo/" to "foo" if "foo" exists in the index and is a gitlink. But becaues "foo/" is used to load the partial index, "foo" is not loaded (is it?) and this could become incorrect no-op. I suggest you go through the pathspec once checking for ones ending with '/'. If so strip_trailing_... may potentially update pathspec, just load full index. If no pathspec ends with '/', strip_trail... is no-op and we can do partial loading safely.

-- 
Duy