Re: [PATCH v2 00/19] Index-v5

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 19, 2013, 18:25 UTC
Message-ID: <7vehauwgnp.fsf@alter.siamese.dyndns.org>
In-Reply-To: <87vc46lacn.fsf@gmail.com>

Thomas Gummerer <t.gummerer@gmail.com> writes:

Show 14 quoted lines

> What I currently did is add a environment variable GIT_INDEX_VERSION
> that is used only if there is no index yet, to make sure existing
> repositories aren't affected and still have to be converted explicitly
> by using git update-index.
>
> For the tests I simply did export GIT_INDEX_VERSION in test-lib.sh to
> allow the addition of GIT_INDEX_VERSION in config.mak.  Should I rename
> that to GIT_INDEX_VERSION_TEST and do something like
>
> set_index_version() {
>         export GIT_INDEX_VERSION=$GIT_INDEX_VERSION_TEST
> }
>
> in test-lib-functions.sh instead, does that make sense?

Mostly Yes ;-).  You have to write it in a valid POSIX shell, i.e.

	set_index_version () {
		GIT_INDEX_VERSION=$TEST_GIT_INDEX_VERSION
                export GIT_INDEX_VERSION
	}