git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: update_linked_gitdir writes relative path to .git/worktrees/<id>/gitdir

From
Duy Nguyen <pclouds@gmail.com>
Date
Feb 8, 2016, 04:56 UTC
Message-ID
<CACsJy8D-dk7aHttHxeGYPuqRUQFx40AJyQQ39gVQvmM2Ttr1pA@mail.gmail.com>
In-Reply-To
<1454893478.2511.5.camel@mattmccutchen.net>
On Mon, Feb 8, 2016 at 8:04 AM, Matt McCutchen <matt@mattmccutchen.net> wrote:
Show 14 quoted lines
> On Sun, 2016-02-07 at 15:56 -0800, Junio C Hamano wrote:
>> Matt McCutchen <matt@mattmccutchen.net> writes:
>>
>> > I noticed that when update_linked_gitdir chooses to update
>> > .git/worktrees/<id>/gitdir, the path it writes is relative, at
>> > least
>> > under some circumstances.  This contradicts the gitrepository-
>> > layout
>> > man page, which says:
>>
>> Duy, is it safe to say that the fix has already been cooking in
>> 'next' as nd/do-not-move-worktree-manually topic,
>
> Yes, looks like that topic removes the buggy functionality.

I'm also pretty sure it's update_linked_gitdir() that writes relative path. So yes nd/do-not-move-worktree-manually should "fix" it. We don't have a way to recover broken gitdir files though.

-- 
Duy
Previous: Matt McCutchenNext: Jeff King
Message 4 of 10 in “update_linked_gitdir writes relative path to .git/worktrees/<id>/gitdir”
  1. Matt McCutchenFeb 6, 2016
  2. Junio C HamanoFeb 7, 2016
  3. Matt McCutchenFeb 8, 2016
  4. Duy NguyenFeb 8, 2016
  5. Jeff KingFeb 8, 2016
  6. Junio C HamanoFeb 8, 2016
  7. Matt McCutchenFeb 9, 2016
  8. Junio C HamanoFeb 9, 2016
  9. Making the "Note from the maintainer" information discoverableMatt McCutchen, Feb 9, 2016
  10. git.txt: encourage bug reporters to test recent versionsMatt McCutchen, Feb 9, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.