Re: update_linked_gitdir writes relative path to .git/worktrees/<id>/gitdir

From: Matt McCutchen <matt@mattmccutchen.net>
Date: Feb 8, 2016, 01:04 UTC
Message-ID: <1454893478.2511.5.camel@mattmccutchen.net>
In-Reply-To: <xmqqlh6w9isp.fsf@gitster.mtv.corp.google.com>

On Sun, 2016-02-07 at 15:56 -0800, Junio C Hamano wrote:

Show 11 quoted lines

> Matt McCutchen <matt@mattmccutchen.net> writes:
> 
> > I noticed that when update_linked_gitdir chooses to update
> > .git/worktrees/<id>/gitdir, the path it writes is relative, at
> > least
> > under some circumstances.  This contradicts the gitrepository-
> > layout
> > man page, which says:
> 
> Duy, is it safe to say that the fix has already been cooking in
> 'next' as nd/do-not-move-worktree-manually topic,

Yes, looks like that topic removes the buggy functionality.

Show 5 quoted lines

> it is very much
> appreciated when reporting bugs people check if a presumed fix is
> already cooking in 'next', try it to verify if it really fixes their
> problem, and send in a "OK fix is good" / "No that does not fix my
> case"?

Sorry to waste your time.  This wasn't documented where I looked,
namely the "Bug Reporting" section on http://git-scm.com/community .
 Here's a straw-man proposed update to that page:

https://github.com/mattmccutchen/git-scm.com/compare/master...bug-reporting-next

If you like it, I will submit it as a pull request. I can propose a similar update to the "REPORTING BUGS" section of the git(1) man page if you like.

Matt