git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] send-email: support coloring dry-run output

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
May 18, 2012, 04:26 UTC
Message-ID
<CACsJy8D=O81cFu0X1g7J++bBaadObkfJ2rsV_WUfDpVrEYotTA@mail.gmail.com>
In-Reply-To
<CAOBOgRaEnFOJ9=ZHczAq_TNerrrMciG8g0SHYDiKrqfhASU-iA@mail.gmail.com>
On Thu, May 17, 2012 at 9:27 PM, Angus Hammond <angusgh@gmail.com> wrote:
Show 7 quoted lines
> This seems like it would be a useful patch for those of us using sendmail.
> I'll admit I don't know any perl at all, but one bit seems a little
> odd to me. Is there a reason you use 3 separate print statements to
> deal with the colours on the Sendmail line, but a regex substitution
> the second time? I have no idea which would be considered the better
> practice but surely we should pick one and be consistent? Unless
> there's some difference between the two that I'm missing.

No reasons. It was what I had in mind at that time and it worked, so I did not bother cleaning up or anything.

-- 
Duy
Previous: Angus Hammond
Message 3 of 3 in “send-email: support coloring dry-run output”
  1. send-email: support coloring dry-run outputNguyễn Thái Ngọc Duy, May 17, 2012
  2. Angus HammondMay 17, 2012
  3. Nguyen Thai Ngoc DuyMay 18, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.