From: Nguyen Thai Ngoc Duy Date: Fri, 18 May 2012 04:26:57 GMT Subject: Re: [PATCH] send-email: support coloring dry-run output Message-ID: In-Reply-To: On Thu, May 17, 2012 at 9:27 PM, Angus Hammond wrote: > This seems like it would be a useful patch for those of us using sendmail. > I'll admit I don't know any perl at all, but one bit seems a little > odd to me. Is there a reason you use 3 separate print statements to > deal with the colours on the Sendmail line, but a regex substitution > the second time? I have no idea which would be considered the better > practice but surely we should pick one and be consistent? Unless > there's some difference between the two that I'm missing. No reasons. It was what I had in mind at that time and it worked, so I did not bother cleaning up or anything. -- Duy