Re: [PATCH v4 3/4] submodule: support running in multiple worktree setup
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Jul 27, 2016, 14:49 UTC
- Message-ID
- <CACsJy8D+pyKXeci8xs+XBmVRat0QjnT94iqPuSz1r8Zbv780jw@mail.gmail.com>
- In-Reply-To
- <20160727041058.GA9015@wheezy.local>
On Wed, Jul 27, 2016 at 6:10 AM, Max Kirillov <max@max630.net> wrote:
Show 20 quoted lines
> Hi. > > On Wed, Jul 20, 2016 at 07:24:18PM +0200, Nguyễn Thái Ngọc Duy wrote: >> + - `remote.*` added by submodules may be per working directory as >> + well, unless you are sure remotes from all possible submodules in >> + history are consistent. > ... >> @@ -1114,7 +1114,7 @@ cmd_sync() >> sanitize_submodule_env >> cd "$sm_path" >> remote=$(get_default_remote) >> - git config remote."$remote".url "$sub_origin_url" >> + git config --worktree remote."$remote".url "$sub_origin_url" >> >> if test -n "$recursive" >> then > > I don't think remote.* should be per-worktree. > > * note that it is sumodule repository, not superproject.
Ah.. silly me, I thought all these were about supermodule. Yes it makes more sense then to share remote.* (just like it's set up after clone).
> It does not even have to have multiple worktrees.
But we can turn a submodule into multiple worktrees after "submodule init" and I don't think sharing remote.* is a problem even in that case.
Show 10 quoted lines
> * it is quite bad to have it different in worktree, because > git fetch then results in different ref updates depending > on where it was called. So whatever issue it was intended > to solve, it hardly made things better. > * I'm not sure I know all use cases of "submodule sync", > but as far as I understand, it should be called when the > submodule repository stays the "same" (however user > defines the "same"), but older url does not work for some > reason. Then I think it is correct to change the remote > url for all worktrees.
-- Duy